Add support for miri to the codebase #7940
Conversation
cwfitzgerald
force-pushed
the
cw/miri
branch
3 times, most recently
from
7b9d7c3 to
8667486
Compare
There was a problem hiding this comment.
This is really nice to have, thank you!
It is too bad to lose the implicit test enumeration, especially because the macro suppresses the dead code warning if you forget to add a test to the list. But I think we can land this change and worry about improvements later.
I played with a macro a bit and came up with this, but it doesn't handle the wasm case (or run_sync, but that shouldn't be hard).
There was a problem hiding this comment.
There is a commented test in this file, it might be worth putting a reminder by the commented test that it needs to be added to the test list if restored.
|
We've discussed inverting the no-op backend condition in the tests. I do want to do this still, but I don't have enough time right now to do it, so I'm going to merge as is, and file a follow up to invert it as I don't want this to bitrot any more than it currently has. |
Wires in support for miri (and potentially ASAN) in the codebase.
Main transform was manually enumerating tests.